Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Path.isRelative #630

Closed
6 tasks
robstoll opened this issue Oct 13, 2020 · 1 comment · Fixed by #632
Closed
6 tasks

add Path.isRelative #630

robstoll opened this issue Oct 13, 2020 · 1 comment · Fixed by #632
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 13, 2020

Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none

Code related feature

expect(path).isRelative()

//instead of

expect(path).feature("isRelative") { isRelative() }

Following the things you need to do:

logic

  • extend PathAssertions with a function isRelative (see other is... functions in PathAssertions as a guideline)
  • implement isRelative in DefaultPathAssertions.kt

api-fluent

  • add isRelative to pathAssertions.kt
  • add @since 0.14.0 (adapt to current milestone) to KDOC
  • add isRelative to Path(Feature)AssertionsSpec in specs-common

api-infix

  • same same but different (see existing toBe ... functions)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@jakubriegel
Copy link
Collaborator

I'll work on this #hactoberfest

jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
@robstoll robstoll linked a pull request Oct 15, 2020 that will close this issue
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 15, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
# This is the 1st commit message:

robstoll#630 add Path.isRelative method

# This is the commit message robstoll#2:

robstoll#482 accept date as string for chronozoneddatetime (robstoll#625)
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
# This is the 1st commit message:

robstoll#630 add Path.isRelative method

# This is the commit message robstoll#2:

robstoll#482 accept date as string for chronozoneddatetime (robstoll#625)
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
jakubriegel pushed a commit to jakubriegel/atrium that referenced this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants