Add samples for pathExpectations of api-infix (#999) #1003

rhushikesh · 2021-10-09T12:35:42Z

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

...um-api-infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/pathExpectations.kt

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

codecov · 2021-10-09T19:51:32Z

Codecov Report

Merging #1003 (1ebfa0e) into main (b1b8b6e) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ebfa0e differs from pull request most recent head 37233cd. Consider uploading reports for the commit 37233cd to get more accurate results

@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         433      433           
  Lines        4359     4359           
  Branches      219      219           
=======================================
  Hits         3961     3961           
  Misses        349      349           
  Partials       49       49

Flag	Coverage Δ
bbc	`80.17% <ø> (ø)`
bc	`80.04% <ø> (ø)`
current	`87.13% <ø> (ø)`
current_windows	`86.21% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tutteli/atrium/api/infix/en_GB/pathExpectations.kt	`100.00% <ø> (ø)`
...teli/atrium/api/infix/en_GB/throwableAssertions.kt	`100.00% <0.00%> (ø)`
...teli/atrium/api/fluent/en_GB/sequenceAssertions.kt	`100.00% <0.00%> (ø)`
...li/atrium/api/infix/en_GB/throwableExpectations.kt	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b8b6e...37233cd. Read the comment docs.

rhushikesh · 2021-10-10T05:07:52Z

Hi @robstoll, I have updated PR with your review comments. Please have a look

robstoll · 2021-10-10T20:19:25Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+            expect(dir) resolve "test_file.ttt" toEqual fileInDir toEndWith Paths.get("ttt")
+            //                                                    |  not reported `toEqual(fileInDir)` already fails
+            //                                  | fails because resolve returns *test_file.ttt and fileInDir equals *test_file.txt
+            //          | use `resolve other { ... }` if you want that all expectations are evaluated


Suggested change

expect(dir) resolve "test_file.ttt" toEqual fileInDir toEndWith Paths.get("ttt")

// | not reported `toEqual(fileInDir)` already fails

// | fails because resolve returns *test_file.ttt and fileInDir equals *test_file.txt

// | use `resolve other { ... }` if you want that all expectations are evaluated

expect(dir) resolve "test_file.ttt" toEqual fileInDir toEndWith Paths.get("ttt")

// | | | not reported `toEqual(fileInDir)` already fails

// | | fails because resolve returns *test_file.ttt and fileInDir equals *test_file.txt

// | use `resolve other { ... }` if you want that all expectations are evaluated

robstoll · 2021-10-10T20:20:55Z

@rhushikesh Thanks for the adjustments. I suggested one small improvement for the comments.
On the other hand, the PR is missing the samples for the functions in pathAssertions.kt (e.g. toBeASymbolicLink) -- I guess you plan to add them as well to this PR. I suggest you go trough apis/fluent-en_GB/atrium-api-fluent-en_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/PathExpectationSamples.kt and check that all functions there have an equivalent in your samples class

rhushikesh · 2021-10-12T18:08:07Z

Hi @robstoll, I have updated PR with your review comments. Also I have added samples for pathAssertions. Please have a look

robstoll

@ratkayandras we are nearly there, some small adjustments and we can merge

...rium-api-infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/pathAssertions.kt

robstoll · 2021-10-12T19:24:55Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+        val dir = tempDir.newDirectory("test.$extension")
+
+
+        expect(dir) extension { // subject is now of type String (actually "txt")


more precise would be (I know you copied it from api-fluent, should be improved there as well)

Suggested change

expect(dir) extension { // subject is now of type String (actually "txt")

expect(dir) extension { // subject inside this block is of type String (actually "txt")

robstoll · 2021-10-12T19:25:10Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+        }
+
+        fails {
+            expect(dir) extension { // subject is now of type String (actually "txt")


Suggested change

expect(dir) extension { // subject is now of type String (actually "txt")

expect(dir) extension { // subject inside this block is of type String (actually "txt")

robstoll · 2021-10-12T19:27:02Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+            expect(dir).extension toEqual "txtt" toEndWith "jpg"
+            //          | subject is now of type String (actually "txt")
+            //          |           | fails because it doesn't equal to "txtt"
+            //          |                       | not reported
+            //          | use `.extension` if you want that all expectations are evaluated


I suggest you style it the same way you did it further below in fileNameFeature

Suggested change

expect(dir).extension toEqual "txtt" toEndWith "jpg"

// | subject is now of type String (actually "txt")

// | | fails because it doesn't equal to "txtt"

// | | not reported

// | use `.extension` if you want that all expectations are evaluated

expect(dir).extension toEqual "txtt" toEndWith "jpg"

// | | | not reported

// | | fails because it doesn't equal to "txtt"

// | subject is now of type String (actually "txt")

// | use ` extension { ... }` if you want that all expectations are evaluated

Note the change for extension { ... } Not your fault, it's actually also wrong in api-fluent. If you don't mind, would be great, if you could fix it there as well => use .extension { ... } there.

robstoll · 2021-10-12T19:28:57Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+    fun fileName() {
+        val dir = tempDir.newDirectory("test_dir")
+
+        expect(dir) fileName { // subject is now of type String (actually "test_dir")


Suggested change

expect(dir) fileName { // subject is now of type String (actually "test_dir")

expect(dir) fileName { // subject inside this block is of type String (actually "test_dir")

same error in api-fluent

robstoll · 2021-10-12T19:30:46Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+    fun fileNameWithoutExtension() {
+        val dir = tempDir.newDirectory("test_dir")
+
+        expect(dir) fileNameWithoutExtension { // subject is now of type String (actually "test_dir")


Suggested change

expect(dir) fileNameWithoutExtension { // subject is now of type String (actually "test_dir")

expect(dir) fileNameWithoutExtension { // subject inside this block is of type String (actually "test_dir")

same same api-fluent

robstoll · 2021-10-12T19:31:10Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+        }
+
+        fails {                                     // because fileNameWithoutExtension equals `test_dir`
+            expect(dir) fileNameWithoutExtension {  // subject is now of type String (actually "test_dir")


Suggested change

expect(dir) fileNameWithoutExtension { // subject is now of type String (actually "test_dir")

expect(dir) fileNameWithoutExtension { // subject inside this block is of type String (actually "test_dir")

robstoll · 2021-10-12T19:31:48Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+                it toEqual dir3 // fails because dir3 and dir does not have same parents
+                it notToBe existing  // still evaluated even though `toEqual(dir3)` already fails
+                //               use `.parent` if you want a fail fast behaviour


Suggested change

it toEqual dir3 // fails because dir3 and dir does not have same parents

it notToBe existing // still evaluated even though `toEqual(dir3)` already fails

// use `.parent` if you want a fail fast behaviour

it toEqual dir3 // fails because dir3 and dir does not have same parents

it notToBe existing // still evaluated even though `toEqual(dir3)` already fails

// use `.parent` if you want a fail fast behaviour

robstoll · 2021-10-12T19:32:21Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+            expect(dir) resolve "test_file.ttt" toEqual fileInDir toEndWith Paths.get("ttt")
+            //          |                       |                 |  not reported `toEqual(fileInDir)` already fails
+            //          |                       | fails because resolve returns *test_file.ttt and fileInDir equals *test_file.txt
+            //          | use `resolve other { ... }` if you want that all expectations are evaluated


Suggested change

// | use `resolve other { ... }` if you want that all expectations are evaluated

// | use `resolve path(other) { ... }` if you want that all expectations are evaluated

robstoll · 2021-10-12T19:32:39Z

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

+            expect(dir) resolve path("test_file.txt") {
+                it toEqual fileInDir // fails
+                it toBe existing     // still evaluated even though `toEqual(fileInDir)` already fails
+                //                      use `.resolve(other).` if you want a fail fast behaviour


Suggested change

// use `.resolve(other).` if you want a fail fast behaviour

// use `resolve other` if you want a fail fast behaviour

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

…/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

robstoll · 2021-10-12T20:38:16Z

@rhushikesh thanks for your 3 contribution to Atrium, you're on 🔥

I am going to fix the remaining things myself. I won't have time to look at 1004 tonight but will do tomorrow

Add samples for pathExpectations of api-infix (robstoll#999)

6bd266f

rhushikesh requested a review from robstoll as a code owner October 9, 2021 12:35

Update comment with infix annotation

5a05971

rhushikesh mentioned this pull request Oct 9, 2021

add Path.notToBeWritable #1001

Closed

11 tasks

robstoll linked an issue Oct 9, 2021 that may be closed by this pull request

add samples for pathExpectations of api-infix #999

Closed

2 tasks

robstoll requested changes Oct 9, 2021

View reviewed changes

rhushikesh added 4 commits October 10, 2021 10:25

Rename toHave sample to toHaveTheDirectoryEntries (robstoll#999)

ac1422c

Use directoryEntries helper function to create DirectoryEntries

b560fca

Use withEncoding helper function to create PathWithEncoding

4c49fcb

Reformat comment for better understanding

1ebfa0e

robstoll reviewed Oct 10, 2021

View reviewed changes

rhushikesh added 2 commits October 12, 2021 22:27

Reformat comment for better understanding

1b28ddf

Add samples for pathAssertions of api-infix (robstoll#999)

37233cd

robstoll requested changes Oct 12, 2021

View reviewed changes

robstoll reviewed Oct 12, 2021

View reviewed changes

...n_GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt Outdated Show resolved Hide resolved

Update apis/infix-en_GB/atrium-api-infix-en_GB-jvm/src/test/kotlin/ch…

1cc0bb0

…/tutteli/atrium/api/infix/en_GB/samples/PathExpectationSamples.kt

robstoll changed the base branch from main to samples-localDate-localDateTime October 12, 2021 20:37

robstoll merged commit f766284 into robstoll:samples-localDate-localDateTime Oct 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add samples for pathExpectations of api-infix (#999) #1003

Add samples for pathExpectations of api-infix (#999) #1003

rhushikesh commented Oct 9, 2021

codecov bot commented Oct 9, 2021 •

edited

Loading

rhushikesh commented Oct 10, 2021

robstoll Oct 10, 2021

robstoll commented Oct 10, 2021

rhushikesh commented Oct 12, 2021

robstoll left a comment

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll Oct 12, 2021

robstoll commented Oct 12, 2021

		val dir = tempDir.newDirectory("test.$extension")


		expect(dir) extension { // subject is now of type String (actually "txt")

	expect(dir) extension { // subject is now of type String (actually "txt")
	expect(dir) extension { // subject inside this block is of type String (actually "txt")

	expect(dir) fileName { // subject is now of type String (actually "test_dir")
	expect(dir) fileName { // subject inside this block is of type String (actually "test_dir")

	expect(dir) fileNameWithoutExtension { // subject is now of type String (actually "test_dir")
	expect(dir) fileNameWithoutExtension { // subject inside this block is of type String (actually "test_dir")

	// \| use `resolve other { ... }` if you want that all expectations are evaluated
	// \| use `resolve path(other) { ... }` if you want that all expectations are evaluated

	// use `.resolve(other).` if you want a fail fast behaviour
	// use `resolve other` if you want a fail fast behaviour

Add samples for pathExpectations of api-infix (#999) #1003

Add samples for pathExpectations of api-infix (#999) #1003

Conversation

rhushikesh commented Oct 9, 2021

codecov bot commented Oct 9, 2021 • edited Loading

Codecov Report

rhushikesh commented Oct 10, 2021

Choose a reason for hiding this comment

robstoll commented Oct 10, 2021

rhushikesh commented Oct 12, 2021

robstoll left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robstoll commented Oct 12, 2021

codecov bot commented Oct 9, 2021 •

edited

Loading