-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add samples for localDateTimeAssertions (#997) #1005
add samples for localDateTimeAssertions (#997) #1005
Conversation
...uent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/localDateTimeAssertions.kt
Show resolved
Hide resolved
...rc/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/LocalDateTimeExpectationSamples.kt
Show resolved
Hide resolved
...infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/localDateTimeAssertions.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 433 433
Lines 4359 4359
Branches 219 219
=======================================
Hits 3961 3961
Misses 349 349
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @robstoll, I have updated PR with your review comments. Please have a look |
...rc/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/LocalDateTimeExpectationSamples.kt
Show resolved
Hide resolved
// subject inside this block is of type Int (actually 2021) | ||
toEqual(2021) | ||
toBeGreaterThan(2020) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} // subject here is back to type LocalDateTime |
same same in other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will make that change
|
||
@Test | ||
fun yearFeature() { | ||
expect(LocalDateTime.of(2021, Month.OCTOBER, 9, 11, 56)).year toEqual 2021 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please also add comment about the subject change. See e.g.apis/infix-en_GB/atrium-api-infix-en_GB-common/src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/AnyExpectationSamples.kt => notToEqualNullFeature
expect(LocalDateTime.of(2021, Month.OCTOBER, 9, 11, 56)).year toEqual 2021 | |
expect(LocalDateTime.of(2021, Month.OCTOBER, 9, 11, 56)).year toEqual 2021 | |
// | subject is now of type Int |
same same further below
Hi @robstoll, I have updated PR with your review comments. Please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhushikesh thanks for adding the comments. I am going to address the remaining details myself
.year { | ||
// subject inside this block is of type Int (actually 2021) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.year { | |
// subject inside this block is of type Int (actually 2021) | |
.year { // subject inside this block is of type Int (actually 2021) |
@rhushikesh thanks for you first contribution to Atrium 👍 |
PR for this issue
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.