Default Result Assertions Fix (again) #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
requested changes
May 7, 2023
Comment on lines
62
to
75
| // @Test | ||
| // fun toBeAFailureResultFix() { | ||
| // val message = "wrong argument" | ||
| // val failure = Result.failure<Int>(IllegalArgumentException(message)) | ||
| // | ||
| // | ||
| // | ||
| // expect(failure) { | ||
| // toBeAFailure<IllegalArgumentException>() | ||
| // } | ||
| // | ||
| // | ||
| // } | ||
| // |
Comment on lines
76
to
78
| // @Test | ||
| // fun toBeAFailureFeature() { | ||
| // val message = "wrong argument" |
| // { apply { toBeAFailure.invoke(this) {} } } | ||
| // ) | ||
| // ) {}) | ||
| //TODO 0.20.0 activate once we have the workaround for #1234 implemented |
| // } | ||
| // } | ||
| // } | ||
| //TODO 0.20.0 activate once we have the workaround for #1234 implemented |
robstoll
approved these changes
May 8, 2023
robstoll
reviewed
May 8, 2023
Comment on lines
+47
to
+50
| val maybeSubjectResult = container.maybeSubject.map { | ||
| onSuccess { null } | ||
| onFailure { it.cause } | ||
| } |
There was a problem hiding this comment.
sorry, I did not really find the time beforehand to take a proper look. This code does nothign as your onSuccess and onFailure only perform side effects. They don't return something which means, maybeSubjectResult is the same as container.maybeSubject. You don't have to do anything. I will improve the code and let you know my result in the end
There was a problem hiding this comment.
Ah I see the error I made sorry about that. Would the solution to be to return some sort of value from the success or failure states and check that?
There was a problem hiding this comment.
the statement doesn't do anything and you still have fixed the issue which means these lines we can just delete :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.