Issue 1286 add asLocalDateTime to java.util.Date #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I saw that the 1.0.0 version is the current one but let me know if it is not @robstoll |
8 tasks
robstoll
requested changes
May 10, 2023
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
Comment on lines
64
to
65
| .toBeAfter(LocalDate.parse("2025-07-17")) // fails | ||
| .toBeBefore(LocalDate.parse("1996-07-17")) // not evaluated/reported because `toBeAfter` already fails |
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...GB/src/jvmTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...GB/src/jvmTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...GB/src/jvmTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...GB/src/jvmTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...rc/jvmMain/kotlin/ch/tutteli/atrium/specs/integration/DateAsLocalDateTimeExpectationsSpec.kt
Show resolved
Hide resolved
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…d fixed code suggestions
|
I forgot to make the change to the asLocalDate so it uses the infix notation will do it tomorrow |
robstoll
reviewed
May 11, 2023
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
robstoll
requested changes
May 11, 2023
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
...B/src/jvmTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/DateSubjectChangerSamples.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Changed infix notation in DateSubjectChangerSamples.kt
|
@Jujusp thanks for you first contribution to Atrium 🙂 👍 I'll take over the remaining formatting issues and then merge into main. Don't forget to ⭐ Atrium if you liked it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added asLocalDateTime to Date.util
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.