rewrite build to build-logic #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---- Slight adoption by robstoll: - still let AbstractKotlinCompile depend on task and not KotlinCompile as this was not good enough in the past (still resulted in warnings)
moreover: - deactivate build-logic.publish-to-tmp-maven-repo and leave TODO for later
moreover: - don't repeat plugins, treat it more like a tree without duplicates - add slowTest/SuiteLogThreshold so that com.github.vlsi.gradle-extensions does not print all tests - move dokka configure into re-usable extension function - disable localRepoElements.outgoing as it causes that the build task suddenly depend on the publish task - make sure DokkaMultiModuleTask executes cleanDokkaHtmlPartial of specs and verbs-internal project as we don't want it - move dokka configuration to root-build convention plugin
and turn it into a single module moreover: - remove println debug statements - remove unused dependency gradle-plugin in publishing - move includeBuild for build-logic plugins into pluginManagement block
this way we also get rid of the UNUSED_VARIABLE warnings
most contributors won't have to do anything in those files hence they should not be that prominently placed in the root dir IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1418, thanks @vlsi
There are still a few things open (search for TODO 1.1.0 in /gradle dir) but I think it is good to merge and we can fix them afterwards
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.