Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Map.toContain... infix samples #1567

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

danherrera
Copy link
Contributor

These are the map infix samples. Please let me know if the samples are what is expected. It wasn't clear to me when certain filler words were required (o, the), but they were in order to compile and have the tests pass. Thank you!


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a668d79) 91.91% compared to head (155e05d) 91.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1567   +/-   ##
=========================================
  Coverage     91.91%   91.91%           
  Complexity      114      114           
=========================================
  Files           424      424           
  Lines          4600     4600           
  Branches        228      228           
=========================================
  Hits           4228     4228           
  Misses          326      326           
  Partials         46       46           
Flag Coverage Δ
current 91.47% <ø> (ø)
current_windows 90.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...fix/en_GB/mapLikeToCntainInAnyOrderOnlyCreators.kt 100.00% <ø> (ø)
.../infix/en_GB/mapLikeToContainInAnyOrderCreators.kt 100.00% <ø> (ø)
...infix/en_GB/mapLikeToContainInOrderOnlyCreators.kt 93.75% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


fails {
expect(mapOf(1 to "apple", 2 to "banana")) toContain o inAny order entry (
keyValue(1) { this toStartWith "b" } // fails because subject does not have this entry
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the feedback from #1565, I will update the comments to be more explanatory

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, waiting for the adjustments and will merge afterwards

@robstoll robstoll added this to the 1.1.0 milestone Oct 14, 2023
@danherrera danherrera marked this pull request as ready for review October 14, 2023 19:59
@robstoll
Copy link
Owner

@danherrera thanks, LGTM 🙂 👍 let's wait for CI.

@robstoll robstoll merged commit ec35715 into robstoll:main Oct 15, 2023
7 checks passed
@robstoll
Copy link
Owner

@danherrera I saw now that you missed to cover entries (you had an entries but it should have been named entriesKeyValue, I already fixed that). I guess I see why you missed it, it is named a bit different in api-infix since it is using the as filler.
expect(mapOf(1 to "a")) toContain o inAny order the pairs(1 to "2")

Do you fancy to write a sample for it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants