-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Map.toContain... infix samples #1567
add Map.toContain... infix samples #1567
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
=========================================
Coverage 91.91% 91.91%
Complexity 114 114
=========================================
Files 424 424
Lines 4600 4600
Branches 228 228
=========================================
Hits 4228 4228
Misses 326 326
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
||
fails { | ||
expect(mapOf(1 to "apple", 2 to "banana")) toContain o inAny order entry ( | ||
keyValue(1) { this toStartWith "b" } // fails because subject does not have this entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the feedback from #1565, I will update the comments to be more explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, waiting for the adjustments and will merge afterwards
...kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/MapLikeToContainInAnyOrderCreatorSamples.kt
Outdated
Show resolved
Hide resolved
...in/ch/tutteli/atrium/api/infix/en_GB/samples/MapLikeToContainInAnyOrderOnlyCreatorSamples.kt
Show resolved
Hide resolved
346c0cf
to
155e05d
Compare
@danherrera thanks, LGTM 🙂 👍 let's wait for CI. |
@danherrera I saw now that you missed to cover Do you fancy to write a sample for it as well? |
These are the map infix samples. Please let me know if the samples are what is expected. It wasn't clear to me when certain filler words were required (
o
,the
), but they were in order to compile and have the tests pass. Thank you!I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.