Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoringCaseWithNotChecker sample #1571

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

robstoll
Copy link
Owner

moreover:

  • make sure we use the order @return...@sample...@since in KDOC
  • add samples to mapLikeToContainSearchBehaviours.kt
  • fix type on mapLikeToCntain => mapLikeToContain (is a BC break)
  • fix linking to ResultExpectationSamples (pointed to the deprecated extension module) in api-fluent
  • add links to ResultExpectationSamples in api-infix
  • add links to SequenceSubjectChangerSamples in api-infix

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll added this to the 1.1.0 milestone Oct 15, 2023
moreover:
- make sure we use the order `@return...@sample...@since` in KDOC
- add samples to mapLikeToContainSearchBehaviours.kt
- fix type on mapLikeToCntain => mapLikeToContain (is a BC break)
- fix linking to ResultExpectationSamples (pointed to the deprecated
  extension module) in api-fluent
- add links to ResultExpectationSamples in api-infix
- add links to SequenceSubjectChangerSamples in api-infix
@robstoll robstoll force-pushed the notToContain.ignoringCase-sample-and-improvements branch from ce3e3e1 to 9498436 Compare October 15, 2023 19:52
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ec35715) 91.91% compared to head (9498436) 91.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1571   +/-   ##
=========================================
  Coverage     91.91%   91.91%           
  Complexity      114      114           
=========================================
  Files           424      424           
  Lines          4600     4600           
  Branches        228      228           
=========================================
  Hits           4228     4228           
  Misses          326      326           
  Partials         46       46           
Flag Coverage Δ
current 91.47% <100.00%> (ø)
current_windows 90.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../api/fluent/en_GB/charSequenceToContainCreators.kt 94.11% <ø> (ø)
...ent/en_GB/charSequenceToContainSearchBehaviours.kt 100.00% <ø> (ø)
...fluent/en_GB/mapLikeToContainInAnyOrderCreators.kt 100.00% <ø> (ø)
...nt/en_GB/mapLikeToContainInAnyOrderOnlyCreators.kt 100.00% <ø> (ø)
...luent/en_GB/mapLikeToContainInOrderOnlyCreators.kt 72.72% <ø> (ø)
...i/fluent/en_GB/mapLikeToContainSearchBehaviours.kt 100.00% <ø> (ø)
...teli/atrium/api/fluent/en_GB/resultExpectations.kt 100.00% <100.00%> (ø)
...atrium/api/fluent/en_GB/sequenceSubjectChangers.kt 100.00% <ø> (ø)
.../tutteli/atrium/api/infix/en_GB/anyExpectations.kt 81.25% <ø> (ø)
.../infix/en_GB/mapLikeToContainInAnyOrderCreators.kt 100.00% <ø> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit e33ce47 into main Oct 15, 2023
12 checks passed
@robstoll robstoll deleted the notToContain.ignoringCase-sample-and-improvements branch October 15, 2023 20:15
@robstoll robstoll linked an issue Oct 15, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ResultExpectationSamples to api-infix
1 participant