Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply publishing plugins, esp. tutteli-dokka only if env PUB is true #1612

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

robstoll
Copy link
Owner

since the update to tutteli-dokka 5.0.0 we sometimes run into an OutOfMemoryException in github_actions. the main change is that we now create one dokkaHtml task per kotlin platform and my guess is, that they have memory leaks (as dkoka had in the past). Hence, we only apply dokka and tutteli-dokka when ENV PUB is given. On my local machine I don't have any problems publishing.


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

since the update to tutteli-dokka 5.0.0 we sometimes run into an
OutOfMemoryException in github_actions. the main change is that we now
create one dokkaHtml task per kotlin platform and my guess is, that they
have memory leaks (as dkoka had in the past). Hence, we only apply
dokka and tutteli-dokka when ENV PUB is given. On my local machine I
don't have any problems publishing.
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bf3874) 91.84% compared to head (3fee2e5) 91.84%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1612   +/-   ##
=========================================
  Coverage     91.84%   91.84%           
  Complexity      114      114           
=========================================
  Files           425      425           
  Lines          4608     4608           
  Branches        228      228           
=========================================
  Hits           4232     4232           
  Misses          330      330           
  Partials         46       46           
Flag Coverage Δ
current 91.40% <ø> (ø)
current_windows 90.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit 04cdf6c into main Nov 14, 2023
14 checks passed
@robstoll robstoll deleted the chore/activate-publishing-only-if-ENV-PUB-given branch November 14, 2023 06:30
@robstoll robstoll added this to the 1.2.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant