Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toHoldThirdPartyExpectation #1704

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Conversation

robstoll
Copy link
Owner

@robstoll robstoll commented Feb 11, 2024

resolves #1702 and fixes #1705


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll added this to the 1.2.0 milestone Feb 11, 2024
@robstoll robstoll force-pushed the feature/toHoldThirdPartyExpectation branch 3 times, most recently from 735d6c5 to 3566073 Compare February 11, 2024 20:24
@robstoll robstoll force-pushed the feature/toHoldThirdPartyExpectation branch from 3566073 to 12157aa Compare February 11, 2024 21:16
@robstoll robstoll removed this from the 1.2.0 milestone Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (edea9ae) 92.02% compared to head (12157aa) 92.14%.

Files Patch % Lines
...li/atrium/logic/creating/filesystem/hints/hints.kt 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1704      +/-   ##
============================================
+ Coverage     92.02%   92.14%   +0.11%     
- Complexity      117      121       +4     
============================================
  Files           423      428       +5     
  Lines          4641     4671      +30     
  Branches        232      232              
============================================
+ Hits           4271     4304      +33     
+ Misses          323      320       -3     
  Partials         47       47              
Flag Coverage Δ
current 91.93% <86.66%> (+0.11%) ⬆️
current_windows 90.85% <86.95%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit 9e2759c into main Feb 11, 2024
22 checks passed
@robstoll robstoll deleted the feature/toHoldThirdPartyExpectation branch February 11, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant