Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use better names than TSub, TExpected, TNotExpected #1706

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

robstoll
Copy link
Owner

same same for type parameters in logic -> creating/transformers


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

same same for type parameters in logic -> creating/transformers
@robstoll robstoll added this to the 1.2.0 milestone Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0e4cfb5) 92.14% compared to head (cde4f81) 92.14%.

Files Patch % Lines
...rium/logic/creating/transformers/SubjectChanger.kt 0.00% 3 Missing ⚠️
...ansformers/impl/BaseTransformationExecutionStep.kt 60.00% 2 Missing ⚠️
...gic/creating/transformers/SubjectChangerBuilder.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1706   +/-   ##
=========================================
  Coverage     92.14%   92.14%           
  Complexity      121      121           
=========================================
  Files           428      428           
  Lines          4671     4671           
  Branches        232      232           
=========================================
  Hits           4304     4304           
  Misses          320      320           
  Partials         47       47           
Flag Coverage Δ
current 91.93% <90.16%> (ø)
current_windows 90.85% <90.16%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit 60b3236 into main Feb 12, 2024
22 checks passed
@robstoll robstoll deleted the improve/better-type-param-names branch February 12, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant