Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper to 6.7 #662

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Update Gradle wrapper to 6.7 #662

merged 2 commits into from
Oct 22, 2020

Conversation

fejd
Copy link
Contributor

@fejd fejd commented Oct 22, 2020

Update Gradle wrapper and normalize file endings for .bat files.


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

Update the Gradle wrapper used by the root and sample
projects from 6.3 to 6.7.
When updating the Gradle wrapper's .bat file, the line endings were
replaced with ^M instead of keeping the existing CRLF ending.

A few samples were already using a .gitattributes file to explicitely
set the line endings for .bat files to CRLF. Move the .gitattributes
file to the root folder and delete the sample specific files.
@fejd fejd requested a review from robstoll as a code owner October 22, 2020 20:11
@fejd
Copy link
Contributor Author

fejd commented Oct 22, 2020

Resolves #637. Sorry for restarting the pull request! I messed up the fork when rebasing the latest from master.

Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem at all, I am going to merge it as soon as the build passes

@robstoll robstoll merged commit 608a996 into robstoll:master Oct 22, 2020
@robstoll
Copy link
Owner

@fejd thanks for your first contribution to Atrium 🙂 👍

There are other issues we could use your help 😉 and don't forget to star Atrium

@robstoll robstoll linked an issue Oct 22, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update gradle wrapper to latest version
2 participants