Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved #676 #830

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Resolved #676 #830

merged 1 commit into from
Mar 5, 2021

Conversation

mai2412
Copy link
Contributor

@mai2412 mai2412 commented Mar 5, 2021

  • copy ComparableAssertionsSample from fluent-api, adjust imports ...api.fluent... to ...api.infix... and ajdust the samples accordingly (always use the infix syntax, never the fluent).
  • check that the sample in the KDoc Intellij shows looks good (ALT+Mouse-click on function name)

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

robstoll
robstoll approved these changes Mar 5, 2021
View reviewed changes
Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mai2412 thanks for your second contribution to Atrium 👍
IMO it looks good, I wait again for you since you marked it as draft

@mai2412 mai2412 marked this pull request as ready for review March 5, 2021 19:38
@robstoll robstoll merged commit a9f8776 into robstoll:master Mar 5, 2021
@robstoll robstoll linked an issue Mar 16, 2021 that may be closed by this pull request
add samples for comparableAssertions of api-infix #676
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robstoll robstoll robstoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add samples for comparableAssertions of api-infix
2 participants
@mai2412 @robstoll