-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add samples for collectionAssertions of api-infix #847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 85.80% 85.82% +0.02%
==========================================
Files 466 466
Lines 4606 4606
Branches 266 266
==========================================
+ Hits 3952 3953 +1
+ Misses 590 589 -1
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szatyinadam thanks for your work, a few improvements and we are good to merge
...st/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/deprecated/CollectionAssertionSamples.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/deprecated/CollectionAssertionSamples.kt
Show resolved
Hide resolved
...st/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/deprecated/CollectionAssertionSamples.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/deprecated/CollectionAssertionSamples.kt
Show resolved
Hide resolved
...infix-en_GB-common/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/collectionAssertions.kt
Outdated
Show resolved
Hide resolved
@szatyinadam I just remembered that we used another syntax in ListAssertionSamples for the comments which is superior to my suggestion. Please take a look and adjust your samples accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, many thanks 👍
Going to wait for the build to pass.
|
I see, that's a bummer, we currently don't allow fail fast within an assertion group block. What we can see here is a weakness of the infix-API, we have not defined
|
...src/test/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/deprecated/ListAssertionSamples.kt
Show resolved
Hide resolved
@szatyinadam hm... the remaining failure is due to my suggestion to inline #847 (comment) I am sorry, looks like my memory of the infix API wasn't that good. Up to you if you want to change this again, I can also do it myself (will most likely do it tomorrow unless you have done it by then) |
@szatyinadam thanks for your first contribution to Atrium 🙂 👍 We could use your help with other issues and don't forget to ⭐ Atrium if you liked it. |
@robstoll Thanks for your patience, and I will definitely look for other issues 🙂 |
Add samples for collectionAssertions of api-infix.
Fix #680 .