remove deprecated modules, ReportFactory, ExpectBuilder and dependOnMe #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
force-pushed
the
remove-deprecated-modules
branch
from
67f8115
to
786993e
Compare
moreover: - adjust packages.md, also remove deprecaed modules there and remove documentation which is no longer used - remove createRegisterJsServicesTask in build.gradle - adjust bbc/bc due to breaking changes (removal of different types). in the same go we have to forgive bc for infix as we no longer have ReporterFactory and since we don't use ascii bullet points in infix tests any more since 0.16.0 - we have established own tests for this aspect - rename RealTranslatorIntSpec to TranslatorIntSpec and remove the existing TranslatorIntSpec which was intended for ReporterFactory based implementations.
robstoll
force-pushed
the
remove-deprecated-modules
branch
from
786993e
to
2519afb
Compare
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
+ Coverage 85.82% 89.75% +3.92%
==========================================
Files 466 407 -59
Lines 4608 4040 -568
Branches 266 211 -55
==========================================
- Hits 3955 3626 -329
+ Misses 589 363 -226
+ Partials 64 51 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moreover:
documentation which is no longer used
in the same go we have to forgive bc for infix as we no longer have
ReporterFactory and since we don't use ascii bullet points in infix
tests any more since 0.16.0 - we have established own tests for this
aspect
existing TranslatorIntSpec which was intended for ReporterFactory
based implementations.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.