Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notToBeGreaterThan and notToBeLessThan #878

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

robstoll
Copy link
Owner

moreover:

  • make the distiction between toEqual and toBeEqualComparingTo clearer
  • rewrite ComparableExpectationsSpec to new nameing and include test
    cases for toBeLessThanOrEqualTo and toBeGreaterThanOrEqualTo where
    the equals/compareTo contract is broken

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

moreover:
- make the distiction between toEqual and toBeEqualComparingTo clearer
- rewrite ComparableExpectationsSpec to new nameing and include test
  cases for toBeLessThanOrEqualTo and toBeGreaterThanOrEqualTo where
  the equals/compareTo contract is broken
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #878 (44cd5e0) into master (97d0133) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   90.80%   90.82%   +0.01%     
==========================================
  Files         407      407              
  Lines        4046     4054       +8     
  Branches      211      211              
==========================================
+ Hits         3674     3682       +8     
  Misses        322      322              
  Partials       50       50              
Flag Coverage Δ
bbc 83.89% <25.00%> (-0.17%) ⬇️
bc 83.79% <25.00%> (-0.17%) ⬇️
current 89.88% <100.00%> (+0.01%) ⬆️
current_windows 88.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tutteli/atrium/api/fluent/en_GB/anyExpectations.kt 100.00% <ø> (ø)
.../tutteli/atrium/api/infix/en_GB/anyExpectations.kt 100.00% <ø> (ø)
.../atrium/api/fluent/en_GB/comparableExpectations.kt 100.00% <100.00%> (ø)
...i/atrium/api/infix/en_GB/comparableExpectations.kt 100.00% <100.00%> (ø)
...rated/kotlin/ch/tutteli/atrium/logic/comparable.kt 100.00% <100.00%> (ø)
...i/atrium/logic/impl/DefaultComparableAssertions.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d0133...44cd5e0. Read the comment docs.

@robstoll robstoll merged commit 1f2cae0 into master Apr 24, 2021
@robstoll robstoll added this to the 0.18.0 milestone Apr 25, 2021
@robstoll robstoll modified the milestones: 0.18.0, 0.17.0 May 21, 2021
@robstoll robstoll deleted the notToBeLess/GreaterThan branch July 7, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant