Assertions refactoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Dec 5, 2024
...rc/integrationTest/java/io/opentelemetry/contrib/jmxscraper/assertions/AttributeMatcher.java
Outdated
Show resolved
Hide resolved
…emetry-java-contrib into assertions-refactoring
SylvainJuge
commented
Dec 5, 2024
| * @param attributes attributes to check as map | ||
| * @return {@literal true} when the attributes match all attributes from this set | ||
| */ | ||
| public boolean matches(Map<String, String> attributes) { |
There was a problem hiding this comment.
[for reviewer] we can move part of the matching logic here as we don't need to generate the assertions from here. details on potential mismatches are provided by the calling code in MetricAssert. Another benefit of doing this is that is allows to not expose elsewhere that it's stored in map.
robsunday
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeMatcherSetclass that is backed by a mapCollection<?>...for method arguments.Setin java collections