Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle P-256 and P-384 account key #24

Closed
dinosaure opened this issue Apr 14, 2021 · 1 comment
Closed

Handle P-256 and P-384 account key #24

dinosaure opened this issue Apr 14, 2021 · 1 comment

Comments

@dinosaure
Copy link
Contributor

dinosaure commented Apr 14, 2021

Currently, letsencrypt acceptes only RSA account key whereas letsencrypt accepts P-256 and P-384. We should be able to handle them.

@mmaker mmaker changed the title Hanfle P-256 and P-384 account key Handle P-256 and P-384 account key Aug 4, 2021
@hannesm
Copy link
Collaborator

hannesm commented Sep 21, 2021

fixed in 0.4.0

@hannesm hannesm closed this as completed Sep 21, 2021
hannesm pushed a commit to hannesm/opam-repository that referenced this issue Sep 21, 2021
CHANGES:

* support EC (P-256, P-384, P-521) account keys (@reynir @hannesm)
  (reported in robur-coop/ocaml-letsencrypt#24 by @dinosaure)
* allow key_type to be passed into the alpn_solver (@hannesm)
* add RFC 7520 test cases (@reynir @hannesm)
* remove astring dependency (@hannesm)
* bugfix: "orders" field in account is Uri.t option, not a list (@hannesm)
  (reported in robur-coop/ocaml-letsencrypt#27 by @torinnd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants