Upgrade to tls.0.13.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @hannesm |
It's seems that let's encrypt support P-256 and P-384 account-key. Should we support them? |
|
the issue is a bit deeper, we'll need JWA support for that (and then there's the question about switching to the opam jose package instead of the custom implementation). this PR seems to address the bin/oacmel only, I'm wondering whether the library needs some adaption as well (but eventually it does not). |
|
thanks, this is fine for unblocking the release train. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 14, 2021
CHANGES: * adapt to X.509 0.12.0 (robur-coop/ocaml-letsencrypt#23 @dinosaure) by completing the pattern match in oacmel (still, only RSA account keys are supported)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible way to upgrade
letsencryptwithtls.0.13.0. I consider any other (than RSA) type of accound-key as unsupported.