Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAIN-1792] Security update for holmes #83

Merged
merged 12 commits into from
Jul 14, 2024
Merged

Conversation

Avi-Robusta
Copy link
Contributor

@Avi-Robusta Avi-Robusta commented Jul 7, 2024

We might want to do something different with the binaries for kube-lineage
tested in arm (locally) and amd
Notes:

  • created a version of kube-lineage without go cve's
  • Removed krew since it was no longer needed with our kubelineage binary
  • removed gcloud and aws cli due to cves, we dont need them in cluster (I made a seperate docker image for local running)
  • updated packages urllib3 and certifi due to cves

PR for kube lineage
tohjustin/kube-lineage#14
my Kube lineage fork:
https://github.com/Avi-Robusta/kube-lineage

@Avi-Robusta Avi-Robusta changed the title Security update for holmes [MAIN-1792] Security update for holmes Jul 7, 2024
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

I think it works correctly, left some minor comments

.github/workflows/build-docker-images.yaml Outdated Show resolved Hide resolved
.github/workflows/build-docker-images.yaml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile.local Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@Avi-Robusta Avi-Robusta merged commit f47a5bb into master Jul 14, 2024
9 checks passed
@Avi-Robusta Avi-Robusta deleted the upgrading_holmes branch July 14, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants