Dict.update alter fn is passed a Result #7107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Anton-4, any concerns about when we land this? It looks like it will break two examples in other roc-lang repos. Otherwise, it breaks a lot of old advent of code examples, but not too much otherwise in the community. |
This was referenced Sep 20, 2024
|
Thanks for the ping Brendan, I'm going to look at roc-lang/examples#207 first and will come back to this after. |
Anton-4
approved these changes
Sep 24, 2024
Anton-4
added a commit
to exercism/roc
that referenced
this pull request
Sep 26, 2024
ageron
pushed a commit
to exercism/roc
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip discussion https://roc.zulipchat.com/#narrow/stream/304641-ideas/topic/Dict.2Eupdate.20alter.20fn.20work.20with.20a.20Result.3F/near/471562715