CMake improvements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvzrv
suggested changes
Jan 4, 2023
| - name: Run tests | ||
| run: | | ||
| cd build | ||
| make test |
There was a problem hiding this comment.
You can do make -C build and drop the cd.
Alternatively: ctest --test-dir build --output-on-failure
There was a problem hiding this comment.
Yeah, it's used to make it similar with other steps.
| if(CMAKE_MAJOR_VERSION LESS 3) | ||
| cmake_minimum_required(VERSION 2.6) | ||
| else() | ||
| cmake_minimum_required(VERSION 2.8.12) |
There was a problem hiding this comment.
What is the reason to support a cmake version from 10 years ago? 👀
There was a problem hiding this comment.
It's still used on one of the systems on which I'm testing roc (some old raspberry pi). While there's no big maintaining burden, I prefer to keep compatibility with older systems, because often people are too lazy to update them, like me :)
Co-authored-by: David Runge <dave@sleepmap.de>
|
@dvzrv thanks for review! |
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools and tests are created in
EXECUTABLE_OUTPUT_PATH(exceptdescr_stats, which have to be inside source dir)EXECUTABLE_OUTPUT_PATHandLIBRARY_OUTPUT_PATHare explicitly markedCACHEdescr_statsis excluded from installation, because it is useful when it is located insideperf_evaldir; it is now the only binary that usesPROJECT_SOURCE_DIRas destinationeperftool,simple_server,simple_clientare by default excluded by installation; new optionINSTALL_DEVTOOLSis added; when it's enabled, those tools are installed intoCMAKE_INSTALL_FULL_BINDIR.hheaders and.pcfile are now installed toominimum cmake version is set back to 2.6 to preserve compatibility with outdated environments (which are checked in roc CI)
-Ilib_advancedis added to.pcfiletests now work and are added to CI