Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter migration: Build system update #104

Closed
20 tasks done
Tracked by #94
Izchomatik opened this issue Jul 13, 2024 · 0 comments
Closed
20 tasks done
Tracked by #94

Flutter migration: Build system update #104

Izchomatik opened this issue Jul 13, 2024 · 0 comments
Assignees
@gavv
Labels
flutter migration

Comments

@Izchomatik
Copy link

Izchomatik commented Jul 13, 2024 •
edited by gavv
Loading

roc-droid Flutter migration child issue.

Restore original gradle features

  • Build properties
    • compileSdk, minSdkVersion, targetSdkVersion
    • ndk version
    • jvm version
    • app versionName & versionCode - load from AndroidManifest.xml or from flutter
  • Android manifest
    • AndroidManifest.xml should have hard-coded version and version code, and build system should automatically update them
    • permissions (see also here)
    • intents
    • service
  • APK building
    • when building APK, check that AndroidManifest and pubspec versions match
    • add project version to APK file name (roc-droid-1.2.3.apk)
    • signing config
  • Spotless
    • gradle targets to run spotless (check & format)
    • doit targets
  • tag.py
    • move to script/make_tag.py
    • extract update_version.py
@Izchomatik Izchomatik mentioned this issue Jul 13, 2024
Open
11 tasks
@gavv gavv mentioned this issue Aug 2, 2024
Merged
@gavv gavv changed the title Flutter migration: Gradle update Flutter migration: Build system update Aug 2, 2024
@gavv gavv mentioned this issue Oct 5, 2024
Closed
gavv added a commit to gavv/roc-droid that referenced this issue Oct 5, 2024
@gavv
Build system update (roc-streaming#104)
20f24d0 
- Get minSdk, targetSdk, compileSdk from gradle.properties
- Get version and version code from AndroidManifest
- Check AndroidManifest and pubspec versions when building APK
- Run spotless linter and dart analyzer
- Run spotless formatter and dart formatter
- Restore APK signing config
gavv added a commit to gavv/roc-droid that referenced this issue Oct 5, 2024
@gavv
Cleanup android manifest (roc-streaming#104)
344a3df
@gavv gavv mentioned this issue Oct 5, 2024
Merged
gavv added a commit to gavv/roc-droid that referenced this issue Oct 5, 2024
@gavv
Build system update (roc-streaming#104)
f5f8b6e 
- Get minSdk, targetSdk, compileSdk from gradle.properties
- Get version and version code from AndroidManifest
- Check AndroidManifest and pubspec versions when building APK
- Run spotless linter and dart analyzer
- Run spotless formatter and dart formatter
- Restore APK signing config
gavv added a commit to gavv/roc-droid that referenced this issue Oct 5, 2024
@gavv
Cleanup android manifest (roc-streaming#104)
eb6ddc7
gavv added a commit to gavv/roc-droid that referenced this issue Oct 5, 2024
@gavv
Cleanup android manifest (roc-streaming#104)
007ef28
Izchomatik pushed a commit that referenced this issue Oct 7, 2024
@gavv @Izchomatik
Build system update (#104)
bd9cf99 
- Get minSdk, targetSdk, compileSdk from gradle.properties
- Get version and version code from AndroidManifest
- Check AndroidManifest and pubspec versions when building APK
- Run spotless linter and dart analyzer
- Run spotless formatter and dart formatter
- Restore APK signing config
Izchomatik pushed a commit that referenced this issue Oct 7, 2024
@gavv @Izchomatik
Cleanup android manifest (#104)
055d2c8
@gavv gavv self-assigned this Oct 8, 2024
@gavv gavv closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavv gavv

Labels
flutter migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavv @Izchomatik