use jul logger by default

[ortex]

fix #3

[gavv]

Three questions:

1. We call setCallback during initialization, so by default we use jul logger. But, if the user will set some logger calbback manually, and then will revert it to default by calling setCallback(null), we will use native default logger instead of jul logger, right? I think it should be fixed.

2. mapLogLevel can throw exception. Is native code that invokes callback ready for exceptions? Maybe better fallback to some specific log level instead of throwing?

   • BTW, if native code is not ready for exceptions, I think we should modify setCallback to suppress exceptions for user-provided callback? E.g. by wrapping in on java side.

3. In the issue we have this part: We should make sure than on android, default logger will send logs to android log (which can be received with adb logcat). Is it true now with using jul?

[ortex]

@gavv

1. Agreed
2. Yeah, we can fallback to some level. Which one? Error?
3. Yeah, that should be true

BTW, if native code is not ready for exceptions, I think we should modify setCallback to suppress exceptions for user-provided callback? E.g. by wrapping in on java side.

or we can add supporting on JNI leve, e.g:

    env->CallVoidMethod(handler_args.callback, handler_args.methID, levelObj, jmodule, jmess);
    if (env->ExceptionCheck()) {
        env->ExceptionDescribe(); // print exception to stderr
        env->ExceptionClear();
    }

[gavv]

2. Yep, I think log error is good fallback.

3. Support at jni level is even better, agree.

[gavv]

Probably printing exception to stderr is not great - user may want to disable stderr, or maybe user doesn't have stderr, e.g. on android.

Maybe better print exception to jul?

[codecov]

Codecov Report

Merging #66 (731e8ef) into main (c389c3e) will increase coverage by 1.05%.
The diff coverage is 88.00%.

@@             Coverage Diff              @@
##               main      #66      +/-   ##
============================================
+ Coverage     69.84%   70.89%   +1.05%     
- Complexity       74       83       +9     
============================================
  Files            23       23              
  Lines           378      402      +24     
  Branches          2        3       +1     
============================================
+ Hits            264      285      +21     
- Misses          108      110       +2     
- Partials          6        7       +1     

Impacted Files	Coverage Δ
.../main/java/org/rocstreaming/roctoolkit/Logger.java	88.46% <88.00%> (-11.54%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gavv]

Maybe rename setCallback0 to setCallbackImp or setCallbackImpl or setCallbackNative?

[gavv]

Consider reworking TestValidLoggerSetLevel to be synchronous (wait for actual logs).

Same for TestInvalidLoggerNotThrows