Added version check to CI checks

[dheerajd5]

This PR adds a version-check to CI checks. It takes the version fetched from git and from the file version.h and compares it.
#497

[gavv]

Two small comments:

• we shouldn't run this check unless we're building a tag naned as v* - because we usually update header before creating a tag

• ideally we shouldn't checkout full history unless we're doing this check, to avoid slowing down regular builds

[adrianopol]

LGTM; also pay attention to gavv's comments please.
Thank you!

[gavv]

@dheerajd5 As you mentioned in the issue, android failure is not related to your pr. I restarted that job.

[dheerajd5]

Two small comments:

• we shouldn't run this check unless we're building a tag naned as v* - because we usually update header before creating a tag
• ideally we shouldn't checkout full history unless we're doing this check, to avoid slowing down regular builds

Hey, So I looked into conditional execution in Actions, to check if we're building a tag with v*, we can probably check the latest commit message, and see if the string matches a v* format.
And for the second point, we can pass an if condition to see what kind of check we're going to run and based of that if it is necessary to pull the full history. I will try to implement the solution to the second point.

Edit: Removed the note asking about to how rebase without coauthoring the commit.

[dheerajd5]

I was looking into the first point, I'm not really sure how to go about it do I check the latest commit and message and try to find a v* matching string?

[gavv]

I think we should extract this from linux-checks into separate job. Only that job will do deep checkout and fetch tags, and other jobs won't be affected. E.g. we can call it release-checks.

The new job then can be enabled conditionally only for properly named tags. Here is how you can do it: https://github.com/roc-streaming/roc-go/blob/6212890ef56528624350571ce13f308e0a3ae11c/.github/workflows/build.yaml#L219C53-L219C53

[dheerajd5]

There are also ways to conditionally execute steps in a job, that's what I've done. Although the solution is a bit hard coded, the workflow only executes the step, fetch tag, if the script that is going to be run is version-check.

But in this case, there was no way that I was aware of where I could conditionally run it based on the tag name.

I'll go ahead with the solution you suggested.

[dheerajd5]

Hey, so I implemented the changes, but it's not passing a few unrelated tests. I don't really have an idea why, Namely, the macos13 series, Here's the workflow run https://github.com/dheerajd5/roc-toolkit/actions/runs/6157211700 and here's the commit page, (dheerajd5@64f2fd6)

[gavv]

Hey, so I implemented the changes, but it's not passing a few unrelated tests. I don't really have an idea why, Namely, the macos13 series

Could you please fetch fresh develop and rebase on it? Should be fixed now.

[dheerajd5]

Hey so I did what you told, it has passed all the checks now. It hasn't run the check I've written cause I didn't upload this with a version tag.

[gavv]

Thanks. Tested it in a fork, there were problems.

Follow-up commit with fixes: 0266785

Changes:

• renamed "package" workflow to "release" and moved release checks to that workflow
• replaced "fetch-tags" with "fetch-depth" because of this issue: Can't fetch with fetch-tags when triggered by tag actions/checkout#1467
• removed ">&2" because errors were not displaying in github actions log (@adrianopol FYI)

[dheerajd5]

Ahh, sorry I couldn't submit a more complete code, but enjoyed working, thanks guys @gavv @adrianopol

[gavv]

You're welcome!