Skip to content

Commit

Permalink
Fixed issue where some templates were not found
Browse files Browse the repository at this point in the history
Mainly roc-template-web-app-react

This started to happen because we now have more than 30 repositories (31) which causes a pagination by default in the GitHub API. With this change we have increased this limit to 100 which will work for now and we will need to revisit this again soon to handle pagination more correctly for the future if we get more than 100 repositories.
  • Loading branch information
dlmr authored Jul 12, 2017
1 parent 5af65e9 commit b367d21
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/commands/init/githubHelpers.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import got from 'got';

export function getOfficialTemplates() {
return got('https://api.github.com/users/rocjs/repos', {
// TODO Implement pagination support before we reach over 100 repositories
return got('https://api.github.com/users/rocjs/repos?per_page=100', {
json: true,
})
.then(response => response.body)
Expand Down

0 comments on commit b367d21

Please sign in to comment.