make the event loop accessible in App #113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app needs to run a child process (in my case I wanted to open $EDITOR to edit a file), we need to be able to stop and restart the event loop.
This PR adds a
loop
field to the vxfw.App struct, so the loop is accessible.This allows, e.g.
Without this you can still run a child process and open an editor, but it's unresponsive to commands as they're being consumed by EventLoop's ttyRun thread.