-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor typo fixing and code refactoring #2
Conversation
README.md
Outdated
| Images (kitty) | ✅ | ✅ | ✅ | | ||
| Images (iterm2) | ❌ | ❌ | ✅ | | ||
| Video | ❌ | ❌ | ✅ | | ||
| Dank | 🆗 | 🆗 | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What formatter did you use? I use prettier for markdown files and it did the formatting of this table automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this one:
https://marketplace.visualstudio.com/items?itemName=darkriszty.markdown-table-prettify
Should I revert that formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's stick with what prettier outputs. Thanks
src/cell.zig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be renamed Cell.zig
I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah, will do
Thanks! A couple comments left inline. I appreciate it! Always like to have it be more idiomatic :) The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh....seems like the file rename isn't here?
Yeah, had to do a |
Hi! Great work with this TUI library!
I'd like to contribute these fixes:
.gitattributes
file for Zig projects.build.zig
a little, hopefully it's a bit clearer. Also, nowzig build
will run all steps.outer: while
in examples was redundant since there's only one loop to break from.switch
expressions don't allow breaking from them, so breaking is only for loops, i.e.while
andfor
.return MyType{...};
, it's more idiomatic to writereturn .{...};
.\n
like here:log.debug("event: {}\r\n", .{event});
.Please tell me if something doesn't make sense, I'll be sure to fix it!