Add GitHub workflow to edit spec file post rockstor-core release #18

[FroggyFlox]

Fixes #18
This issue is directly related to rockstor/rockstor-core#2596.
@phillxnet, @Hooverdan96, ready for review.

We currently manually edit rockstor.spec after each release created in rockstor-core; this process is cumbersome, time-consuming, and prone to error when done manually.

This pull request adds a GitHub workflow to perform the required modifications automatically and create a pull request accordingly.

[FroggyFlox]

A quick note on the following:

        env:
          AUTHOR: "Philip Guyton"
          EMAIL: "philip@yewtreeapps.com"

We could here use repository variables instead of hard-coding in the yaml file. While this functionally makes no difference at first, I just realized that we need to commit changes were we to update any of these values. If we use repository variables, we would just need to update the values in Github's UI. The latter is simpler, but the former is more "traceable".
In the end, the result is the same, though, so I'm open to both.

[Hooverdan96]

Quick question, since I am clearly no expert here. In line 70:
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

Where does this email identifier come from. Is it specific to the github actions/bot? Or connected to the repo account?

If it makes any difference, on your above comment, I would think parameterizing consistently (even if we all hope that Phil will stick around for another century :) ) would make more sense?

[phillxnet]

If we use repository variables, we would just need to update the values in Github's UI.

Agreed, this seems like a nicer alternative: Plus we do have 3 folks who have Admin across our GitHub Org.

[FroggyFlox]

Thanks a lot to you both for the feedback. I'll go ahead and use repository variables for that, then.

@Hooverdan96, to answer your question about the email address: yes, this corresponds to the GitHub Action bot account and allows to have its avatar and email address be displayed properly in GitHub's UI. I should have commented/documented that properly, my apologies. See this link for a nice roundup/description: actions/checkout#1184

[FroggyFlox]

I have now force-pushed the switch to using repository variables for the RPM author and email information.

[phillxnet]

@FroggyFlox merging the second of your 3 repo semi-automated release prep pull requests.

I'm not able to review unfortunately, bar a read-through, given GitHub Actions is rather new to me.

@Hooverdan96 we have moved to using "The Rockstor Project" and the support email for the vars used by this automation. Hopefully that won't cause a problem down the line. But it seemed like the time do switch give we intend to use this mechanism for both the new master (Stable) run and the new testing run 🤞 .