Merge pull request #528 from roclark/fix-fb-position

Fix issue pulling football league positions
roclark · Nov 13, 2020 · 4c3c1e7 · 4c3c1e7
2 parents 9b6039f + 20d3ec0
commit 4c3c1e7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/sportsreference/fb/team.py b/sportsreference/fb/team.py
@@ -165,12 +165,15 @@ def _records(self, record_line):
         records = record_line.lower().replace('record: ', '')
         records_split = records.split(',')
         if len(records_split) != 3:
-            return None, None, None
+            return None, None, None, None
         record, points, position = records_split
         points = re.sub(' point.*', '', points).strip()
         position = re.sub(r'\(.*\)', '', position).strip()
         league = re.sub('.* in ', '', position).title()
-        position = re.findall(r'\d+', position)[0]
+        try:
+            position = re.findall(r'\d+', position)[0]
+        except IndexError:
+            position = None
         return record, points, position, league
 
     def _goals(self, goals_line):

diff --git a/tests/unit/test_fb_team.py b/tests/unit/test_fb_team.py
@@ -52,7 +52,14 @@ def test_records_missing_result(self):
 
         output = self.team._records(html)
 
-        assert output == (None, None, None)
+        assert output == (None, None, None, None)
+
+    def test_records_missing_position(self):
+        html = 'Record: 5-0-0, 15 points (3.0 per game),  Premier League'
+
+        output = self.team._records(html)
+
+        assert output == ('5-0-0', '15', None, 'Premier League')
 
     def test_goals_missing(self):
         html = 'Goals: 20 (2.5 per game), Goals Against: 11 (1.38 per game)'