Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include coach #285

Closed
jar211 opened this issue Nov 28, 2019 · 3 comments · Fixed by #527
Closed

Include coach #285

jar211 opened this issue Nov 28, 2019 · 3 comments · Fixed by #527
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jar211
Copy link

jar211 commented Nov 28, 2019

Is your feature request related to a problem? Please describe.
Coaches can have a significant influence on the culture of the team and have been shown to have a significant influence on win %. When they change teams the winning follow them.

Describe the solution you'd like
I'd like to see the coach included in the data set for the team.

Describe alternatives you've considered
I could scrape the page myself.

@roclark roclark self-assigned this Nov 29, 2019
@roclark roclark added the enhancement New feature or request label Nov 29, 2019
@roclark roclark added this to the Release 0.5.0 milestone Nov 29, 2019
@roclark
Copy link
Owner

roclark commented Nov 29, 2019

Hey @jar211, great idea! I will work on adding this to the next release, as I agree, coaches are a vital part of the equation and should be included. Thanks for the suggestion! I will close this once the update is merged.

@roclark roclark modified the milestones: Release 0.5.0, Release 0.6.0 Mar 26, 2020
@l3str4nge
Copy link
Contributor

Hello, @roclark are you started working on this issue? I am interesting to contribute and I am wonder which issue I could take for 0.6.0 release :)

@roclark
Copy link
Owner

roclark commented May 2, 2020

Hello @mateuszz0000, thanks for reaching out! I have not made any progress on this one yet, so you are free to contribute as desired! I will be very happy to check out a PR when you are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants