Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coach to Roster #527

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add coach to Roster #527

merged 1 commit into from
Nov 13, 2020

Conversation

roclark
Copy link
Owner

@roclark roclark commented Nov 13, 2020

The coach or manager's full name is now a property that can be retrieved from a team's Roster class.

Closes #285

@roclark roclark added the enhancement New feature or request label Nov 13, 2020
@roclark roclark added this to the Release 0.6.0 milestone Nov 13, 2020
@roclark roclark self-assigned this Nov 13, 2020
The coach or manager's full name is now a property that can be retrieved
from a team's Roster class.
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #527 (b47b34b) into master (8383487) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13108    13168   +60     
=======================================
+ Hits        13105    13165   +60     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/mlb/constants.py 100.00% <ø> (ø)
sportsreference/nba/constants.py 100.00% <ø> (ø)
sportsreference/nba/nba_utils.py 100.00% <ø> (ø)
sportsreference/ncaab/constants.py 100.00% <ø> (ø)
sportsreference/ncaaf/constants.py 100.00% <ø> (ø)
sportsreference/nfl/constants.py 100.00% <ø> (ø)
sportsreference/nhl/constants.py 100.00% <ø> (ø)
sportsreference/mlb/roster.py 100.00% <100.00%> (ø)
sportsreference/nba/roster.py 100.00% <100.00%> (ø)
sportsreference/ncaab/roster.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8383487...b47b34b. Read the comment docs.

@roclark roclark merged commit 9b6039f into master Nov 13, 2020
@roclark roclark deleted the add-coaches branch November 13, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include coach
2 participants