Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Football tests fail on date of scheduled game #408

Closed
roclark opened this issue Apr 26, 2020 · 0 comments · Fixed by #409
Closed

Football tests fail on date of scheduled game #408

roclark opened this issue Apr 26, 2020 · 0 comments · Fixed by #409
Assignees
Labels
bug Something isn't working
Milestone

Comments

@roclark
Copy link
Owner

roclark commented Apr 26, 2020

Describe the bug
If tests are run on a day where the sample football team was scheduled to play, a ValueError will fail to raise when expected. This makes the test fail if it happens to be run on a scheduled day.

To Reproduce
Run the testing suite on a day where the sample football team was scheduled to play, such as April 26, 2020.

Expected behavior
The tests should yield the expected results regardless of the date.

Desktop (please complete the following information):

  • OS: Affects all
  • Sportsreference Version: 0.5.0 and above

Additional context
The chances of running into this are very small, but it can be extremely challenging to debug, especially in different regions.

@roclark roclark added the bug Something isn't working label Apr 26, 2020
@roclark roclark added this to the Release 0.6.0 milestone Apr 26, 2020
@roclark roclark self-assigned this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant