Fix issue with FB schedule using invalid date #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the current datetime could run into an issue for the football schedule tests if the date a test was run happened to be an actual date on the team's schedule would fail to throw a ValueError. Instead, a date that is known to not be on the team's schedule should be used to ensure the tests can complete regardless of the date run. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 49 +1
Lines 10616 10631 +15
=======================================
+ Hits 10613 10628 +15
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the current datetime could run into an issue for the football schedule tests if the date a test was run happened to be an actual date on the team's schedule would fail to throw a
ValueError. Instead, a date that is known to not be on the team's schedule should be used to ensurethe tests can complete regardless of the date run.
Fixes #408
Signed-Off-By: Robert Clark robdclark@outlook.com