Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with MLB tests #151

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Fix issue with MLB tests #151

merged 1 commit into from
Aug 2, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Aug 2, 2019

The MLB unit tests were not properly throwing an HTTPError, causing the test to fail. The requests have now been properly mocked and HTTPErrors are thrown as expected.

Signed-Off-By: Robert Clark robdclark@outlook.com

The MLB unit tests were not properly throwing an HTTPError, causing the
test to fail. The requests have now been properly mocked and HTTPErrors
are thrown as expected.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Aug 2, 2019
@roclark roclark added this to the Release 0.4.4 milestone Aug 2, 2019
@roclark roclark self-assigned this Aug 2, 2019
@roclark roclark merged commit dcfb9ae into master Aug 2, 2019
@roclark roclark deleted the patch/fix-mlb-unit-tests branch August 2, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant