Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NBA Boxscore integration tests #201

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Fix NBA Boxscore integration tests #201

merged 1 commit into from
Sep 23, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 23, 2019

The NBA Boxscore integration tests randomly started failing while attempting to create an instance of the Boxscore class. The issue is now resolved, allowing the tests to complete as expected again.

Fixes #200

Signed-Off-By: Robert Clark robdclark@outlook.com

The NBA Boxscore integration tests randomly started failing while
attempting to create an instance of the Boxscore class. The issue is now
resolved, allowing the tests to complete as expected again.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Sep 23, 2019
@roclark roclark self-assigned this Sep 23, 2019
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          43       43           
  Lines        9299     9299           
=======================================
  Hits         9297     9297           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb38db...2f890fa. Read the comment docs.

@roclark roclark merged commit 379795c into master Sep 23, 2019
@roclark roclark deleted the patch/fix-nba-tests branch September 23, 2019 00:45
@roclark roclark added this to the Release 0.4.5 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix NBA Boxscore tests
1 participant