Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Actions #208

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 30, 2019

Given the limitations of Travis-CI such as delayed or stalled builds, erroneous errors and failures, frequent timeouts, and lack of support for Windows, it would be preferable to move to GitHub Actions to solve the above issues as well as reduce the number of third-party integrations with this repository.

Fixes #199

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the enhancement New feature or request label Sep 30, 2019
@roclark roclark added this to the Release 0.5.0 milestone Sep 30, 2019
@roclark roclark self-assigned this Sep 30, 2019
@roclark roclark force-pushed the patch/support-github-actions branch 4 times, most recently from b9e4886 to 67680e6 Compare September 30, 2019 19:19
@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #208 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files          43       42       -1     
  Lines        9365     9356       -9     
==========================================
- Hits         9363     9354       -9     
  Misses          2        2
Impacted Files Coverage Δ
sportsreference/constants.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f08d0...e581779. Read the comment docs.

@roclark roclark force-pushed the patch/support-github-actions branch 8 times, most recently from 2adf516 to 69d467c Compare September 30, 2019 22:31
roclark and others added 2 commits September 30, 2019 17:42
Given the limitations of Travis-CI such as delayed or stalled builds,
erroneous errors and failures, frequent timeouts, and lack of support
for Windows, it would be preferable to move to GitHub Actions to solve
the above issues as well as reduce the number of third-party
integrations with this repository.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
Given the vast improvements of GitHub Actions over Travis-CI, Actions
should be used wholesale in-place of Travis-CI, and support for Travis
should be dropped from this project.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark merged commit 6281078 into master Oct 1, 2019
@roclark roclark deleted the patch/support-github-actions branch October 1, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to GitHub Actions
1 participant