Fix HTTP redirect issues in NCAAB module #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NCAAB module was throwing unhandled HTTP 301 status codes for all pages, which masked 404 errors in the case of pages not being present, and therefore allowing false positives for pulling data from the website. The 301 codes were being thrown as the server automatically redirects from http:// to https:// for the linked pages, and should therefore default to https:// for the URLs to ensure proper codes are always returned while pulling webpages. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 42 42
Lines 9356 9356
=======================================
Hits 9354 9354
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NCAAB module was throwing unhandled HTTP 301 status codes for all pages, which masked 404 errors in the case of pages not being present, and therefore allowing false positives for pulling data from the website. The 301 codes were being thrown as the server automatically redirects from http:// to https:// for the linked pages, and should therefore default to https:// for the URLs to ensure proper codes are always returned while pulling webpages.
Fixes #215
Signed-Off-By: Robert Clark robdclark@outlook.com