Fix issue with future NFL boxscore errors #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For games that are yet to occur which are listed in an NFL team's schedule, an error will be thrown while attempting to parse a score for the game when none exists. To circumvent this issue, not only should the points be checked if they are None, they should also be checked if they are empty. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 42 42
Lines 9356 9357 +1
==========================================
+ Hits 9354 9355 +1
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For games that are yet to occur which are listed in an NFL team's schedule, an error will be thrown while attempting to parse a score for the game when none exists. To circumvent this issue, not only should the points be checked if they are
None, they should also be checked if they are empty.Fixes #219
Signed-Off-By: Robert Clark robdclark@outlook.com