Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add College Football Playoff (CFP) rankings #278

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Nov 25, 2019

The weekly College Football Playoff rankings should be added similar to the AP rankings module. The new class allows queries for the current rankings, as well as a complete list of rankings in a condense and verbose format.

Closes #224

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the enhancement New feature or request label Nov 25, 2019
@roclark roclark added this to the Release 0.5.0 milestone Nov 25, 2019
@roclark roclark self-assigned this Nov 25, 2019
@roclark roclark force-pushed the add-ncaab-cfp-rankings branch 3 times, most recently from 55ef5fb to a8820b6 Compare November 25, 2019 18:34
The weekly College Football Playoff rankings should be added similar to
the AP rankings module. The new class allows queries for the current
rankings, as well as a complete list of rankings in a condense and
verbose format.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #278 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   99.96%   99.96%   +<.01%     
==========================================
  Files          42       42              
  Lines        9371     9432      +61     
==========================================
+ Hits         9368     9429      +61     
  Misses          3        3
Impacted Files Coverage Δ
sportsreference/ncaaf/constants.py 100% <100%> (ø) ⬆️
sportsreference/ncaaf/rankings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f8965...3be109f. Read the comment docs.

@roclark roclark merged commit 39956aa into master Nov 25, 2019
@roclark roclark deleted the add-ncaab-cfp-rankings branch November 25, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add College Football Playoff rankings to NCAAF
1 participant