Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FB table IDs #480

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Update FB table IDs #480

merged 1 commit into from
Sep 27, 2020

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 27, 2020

The IDs used for tables in the FB modules have been updated on the website, and the classes need to be changed to reflect those updates in order to grab information again.

Fixes #479

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the bug Something isn't working label Sep 27, 2020
@roclark roclark added this to the Release 0.6.0 milestone Sep 27, 2020
@roclark roclark self-assigned this Sep 27, 2020
@roclark roclark force-pushed the add-fb-leagues branch 2 times, most recently from 89a8e14 to d0c72ec Compare September 27, 2020 20:50
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #480 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          54       55    +1     
  Lines       13004    13006    +2     
=======================================
+ Hits        13001    13003    +2     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/fb/constants.py 100.00% <ø> (ø)
sportsreference/fb/league_ids.py 100.00% <100.00%> (ø)
sportsreference/fb/roster.py 100.00% <100.00%> (ø)
sportsreference/fb/schedule.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff9c38...77a67f4. Read the comment docs.

The IDs used for tables in the FB modules have been updated on the
website, and the classes need to be changed to reflect those updates in
order to grab information again.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue pulling football stats
1 participant