Fix NBA Boxscore summary #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
added
bug
The NBA Boxscores were showing no game summaries for the per-quarter scores for both teams. It appears sports-reference.com was updated to include a space in the class attribute for the game summary table, throwing off the parser. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-nba-boxscore-summary
branch
from
e397575
to
a9339ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13091 13094 +3
=======================================
+ Hits 13088 13091 +3
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NBA Boxscores were showing no game summaries for the per-quarter scores for both teams. It appears sports-reference.com was updated to include a space in the class attribute for the game summary table, throwing off the parser.
Fixes #455
Signed-Off-By: Robert Clark robdclark@outlook.com