-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Put SerAPI in maintenance mode. #318
Conversation
7224c22
to
946211b
Compare
946211b
to
436a0e4
Compare
Exciting step! I guess I need to port Alectryon, but… do we really have feature parity between LSP and SerAPI? I would worry about these:
|
SerAPI will be OK as long as the Coq API it uses (the STM) is still in Coq, the roadmap for that is not clear. Actually most of the SerAPI API maps directly to coq-lsp, so if someone would be willing to port it the API could be kept even beyond Stm removal from Coq.
For now we only print this info as a debug information, but the request can be added easily, PR incoming.
Pull diagnostics are not yet implemented, but they are a priority and the checking engine supports them, main TODO is the LSP plumbing, will get to it soon I hope; also a There is a hack in coq-lsp which is to query for info (or hover) etc... with the last point of the document, but indeed it is a hack, also you could use the fileProgress notification, but that's also a hack.
Yes, LSP server uses the same (a bit improved actually) Goal datatype, see https://github.com/ejgallego/coq-lsp/blob/main/etc/doc/PROTOCOL.md#goal-display There are some other bits upcoming in PRs such as support for obligations (which tells you about holes in the document) |
Thanks!
Ah, nice. It's one way to go at least :)
Excellent, thanks! |
Thanks to everyone that helped and used this project for almost 7 years!
The following issues are solved by coq-lsp:
closes #252, closes #261, closes #234, closes #202, closes #117,
closes #49, closes #32, closes #26, closes #24, closes #21,
closes #18, closes #13