Support the extraction plugin #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to re-run tests when plugins change too!
We add a test that is complete w.r.t. the 3 genargs as of today. Co-authored-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
force-pushed
the
support-extraction
branch
from
5bddf00 to
0fd081e
Compare
|
Hi @toku-sa-n , I have taken the freedom to finish this PR, I will merge once the CI is ready. Thanks for starting this! |
ejgallego
added a commit
that referenced
this pull request
Feb 21, 2024
Support the extraction plugin
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Feb 21, 2024
CHANGES: - [serlib] Support `btauto` Coq plugin (@ejgallego, rocq-archive/coq-serapi#362) - [serlib] Support `extraction` Coq plugin (@ejgallego, @toku-sa-n, rocq-archive/coq-serapi#375, fixes rocq-archive/coq-serapi#371) - [general] Make licensing clearer (@ejgallego, @palmskog, @SnarkBoojum, rocq-archive/coq-serapi#361, closes rocq-archive/coq-serapi#266)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Feb 21, 2024
CHANGES: - [serlib] Support `btauto` Coq plugin (@ejgallego, rocq-archive/coq-serapi#362) - [serlib] Support `extraction` Coq plugin (@ejgallego, @toku-sa-n, rocq-archive/coq-serapi#375, fixes rocq-archive/coq-serapi#371) - [general] Make licensing clearer (@ejgallego, @palmskog, @SnarkBoojum, rocq-archive/coq-serapi#361, closes rocq-archive/coq-serapi#266)
|
Ah, sorry for taking up your time, and thank you for the implementation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #371