Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run e2e and integration tests only when api-service or dashboard changes #1666

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Oct 22, 2024

Describe your changes

The e2e and integration tests must only run when we change the dashboard or API-service.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from code. If you can confirm that it works as expected functionally (runs if something changed, and not if nothing changed), then approved. UPDATE: I can see the latter case confirmed in this PR I guess, as they haven't run here.)

@jannisvisser
Copy link
Contributor

@gulfaraz actually 1 more comment. The integration tests are not dependent on ibf-dashboard changes right. They only test backend api-calls.

Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in PR

@gulfaraz
Copy link
Member Author

@jannisvisser You are right. I've updated the workflow accordingly.

@gulfaraz gulfaraz merged commit 085c18c into master Oct 22, 2024
8 checks passed
@gulfaraz gulfaraz deleted the ci.test-workflow branch October 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants