Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guide-How_to_set_up_an_instance.md #1134

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Conversation

lotjeredcross
Copy link
Contributor

I added two things:

  • A note to specifically make sure to fill in the Google Sheets ID in the code
  • How to connect to a specific URL, making use of Github pages

I added two things: 
- A note to specifically make sure to fill in the Google Sheets ID in the code
- How to connect to a specific URL, making use of Github pages
@lotjeredcross
Copy link
Contributor Author

@DGorsseRedCross @elwinschmitz could you please check? :)

Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another step related to the custom (sub-)domain hosting option as well..

And the list of URL-options at the bottom of the file should only be a comparison-of-properties, not a list of steps-to-do. (So therefore I added that to the checklist up top).

Also;
This will resolve: #1025 ;)

docs/Guide-How_to_set_up_an_instance.md Outdated Show resolved Hide resolved
docs/Guide-How_to_set_up_an_instance.md Show resolved Hide resolved
docs/Guide-How_to_set_up_an_instance.md Outdated Show resolved Hide resolved
docs/Guide-How_to_set_up_an_instance.md Outdated Show resolved Hide resolved
Add step related to the custom (sub-)domain hosting option
Add optional steps to use (sub-)domain deployment to the checklist

Resolves #1025
elwinschmitz
elwinschmitz previously approved these changes Oct 22, 2024
@elwinschmitz elwinschmitz merged commit 6a117ee into main Oct 22, 2024
4 checks passed
@elwinschmitz elwinschmitz deleted the lotjeredcross-patch-1 branch October 22, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants