Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built types, remove custom type declarations #79

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

chrissantamaria
Copy link
Contributor

Followup to #78 - looks like the updated types aren't being recognized by package consumers, as the types field in package.json is pointing to a custom written index.d.ts in the repo root. I'm not sure if this has a purpose now (perhaps existed before this repo was natively written in TypeScript?), but I've gone ahead and removed it in favor of the built types in dist/index.d.ts.

Copy link
Owner

@roderickhsiao roderickhsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was previously added by open source before we migrated to typescript, should be good to removed.

thanks

@roderickhsiao roderickhsiao merged commit ea92874 into roderickhsiao:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants