Expose 'catalogue' method as consistent API in example groups #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rspec-puppet pre-1.0, the catalogue method was available in all example groups with no arguments. This has been restored, so the catalogue is easily accessible in derivative example groups where subject is overridden (e.g. so subject can be redefined as a resource inside the catalogue).
|
You really shouldn't be relying on an internal API method like that. |
rodjek
pushed a commit
that referenced
this pull request
Jan 25, 2014
Expose 'catalogue' method as consistent API in example groups
|
is the expected usage instead of using catalogue? |
|
never mind, saw the note in #151 about the breaking change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rspec-puppet pre-1.0, the catalogue method was available in all example groups with no arguments. This has been restored, so the catalogue is easily accessible in derivative example groups where subject is overridden (e.g. so subject can be redefined as a resource inside the catalogue).
I don't think without this there's an easy way to get at the catalogue without knowing the parent example group type (class, define, host).