Support sensitive #781
Merged
Support sensitive #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet does class matching to detect parameter types now, so quacking like a sensitive is not enough anymore; it leads to very confusing and misleading error messages.
alexjfisher
added a commit
to alexjfisher/puppet-chrony
that referenced
this pull request
Jul 15, 2020
2.7.9 contains rodjek/rspec-puppet#781 and that appears to have broken our tests. Fix was pretty simple, but not sure the rspec-puppet PR was meant to break existing test suites like this.
alexjfisher
added a commit
to alexjfisher/puppet-chrony
that referenced
this pull request
Nov 16, 2020
2.7.9 contained rodjek/rspec-puppet#781 and that broke our tests. 2.7.9 was pulled from rubygems, but this breaking change is back in 2.8.0 :(
kenyon
pushed a commit
to voxpupuli/puppet-chrony
that referenced
this pull request
Nov 16, 2020
2.7.9 contained rodjek/rspec-puppet#781 and that broke our tests. 2.7.9 was pulled from rubygems, but this breaking change is back in 2.8.0 :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing #464 in preparation for the 2.8.0 release (can no longer push to the original PR for some reason).
Closes #464