fix: in some cases the syntax file can be evaluated before ftplugin #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two users, @shadowwa and @dmaes reported errors where vim 9.1 was not happy about the variable g:puppet_display_errors not being defined when evaluating `syntax/puppet.vim`. They found out that the order the plugin scripts were loaded did not reflect my current understanding of how vim loads plugin files: the syntax file was loaded before the ftplugin script, so the variable was indeed not yet defined. Since the variable is only used in the syntax script, we can declare its default value there if the variable doesn't exist (instead of in the ftplugin file) I've also changed to using the more common values 0/1 for binary flags in order to use vimscript's "truthy/falsy" nature of a variable. (Closes: #151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two users, @shadowwa and @dmaes reported errors where vim 9.1 was not happy about the variable g:puppet_display_errors not being defined when evaluating
syntax/puppet.vim. They found out that the order the plugin scripts were loaded did not reflect my current understanding of how vim loads plugin files: the syntax file was loaded before the ftplugin script, so the variable was indeed not yet defined.Since the variable is only used in the syntax script, we can declare its default value there if the variable doesn't exist (instead of in the ftplugin file)
I've also changed to using the more common values 0/1 for binary flags in order to use vimscript's "truthy/falsy" nature of a variable.
(Closes: #151)